Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose new idea to store the indexation info #2604

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Propose new idea to store the indexation info #2604

merged 2 commits into from
Jan 22, 2025

Conversation

AurelienFT
Copy link
Contributor

No description provided.

xgreenx
xgreenx reviewed Jan 21, 2025
View reviewed changes
crates/fuel-core/src/schema/node_info.rs
);

let mut indexation = Indexation::new();
for kind in IndexationKind::iter() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good way to enforce compiler error=D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:p #2595 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit less optimised but worth the cost imo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change is definitely a good one 👍

@AurelienFT AurelienFT mentioned this pull request Jan 21, 2025
Merged
2 tasks
@AurelienFT AurelienFT marked this pull request as ready for review January 21, 2025 00:07
@AurelienFT AurelienFT requested review from rafal-ch and removed request for Dentosal and MitchTurner January 21, 2025 00:08
@AurelienFT AurelienFT added the no changelog Skip the CI check of the changelog modification label Jan 21, 2025
@rafal-ch rafal-ch merged commit 5b77da5 into rafal/2576_extend_node_info Jan 22, 2025
40 of 43 checks passed
@rafal-ch rafal-ch deleted the showcase_indexation_refacto branch January 22, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafal-ch rafal-ch rafal-ch left review comments

@xgreenx xgreenx xgreenx approved these changes

Assignees
No one assigned
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurelienFT @xgreenx @rafal-ch